Initial commit
This commit is contained in:
Your Name
@@ -0,0 +1,153 @@
|
||||
#
|
||||
# Copyright OpenEmbedded Contributors
|
||||
#
|
||||
# SPDX-License-Identifier: MIT
|
||||
#
|
||||
|
||||
from oeqa.selftest.case import OESelftestTestCase
|
||||
|
||||
import oe.recipeutils
|
||||
|
||||
class Distrodata(OESelftestTestCase):
|
||||
|
||||
def test_checkpkg(self):
|
||||
"""
|
||||
Summary: Test that upstream version checks do not regress
|
||||
Expected: Upstream version checks should succeed except for the recipes listed in the exception list.
|
||||
Product: oe-core
|
||||
Author: Alexander Kanavin <alex.kanavin@gmail.com>
|
||||
"""
|
||||
feature = 'LICENSE_FLAGS_ACCEPTED += " commercial"\n'
|
||||
self.write_config(feature)
|
||||
|
||||
pkgs = oe.recipeutils.get_recipe_upgrade_status()
|
||||
|
||||
regressed_failures = [pkg[0] for pkg in pkgs if pkg[1] == 'UNKNOWN_BROKEN']
|
||||
regressed_successes = [pkg[0] for pkg in pkgs if pkg[1] == 'KNOWN_BROKEN']
|
||||
msg = ""
|
||||
if len(regressed_failures) > 0:
|
||||
msg = msg + """
|
||||
The following packages failed upstream version checks. Please fix them using UPSTREAM_CHECK_URI/UPSTREAM_CHECK_REGEX
|
||||
(when using tarballs) or UPSTREAM_CHECK_GITTAGREGEX (when using git). If an upstream version check cannot be performed
|
||||
(for example, if upstream does not use git tags), you can set UPSTREAM_VERSION_UNKNOWN to '1' in the recipe to acknowledge
|
||||
that the check cannot be performed.
|
||||
""" + "\n".join(regressed_failures)
|
||||
if len(regressed_successes) > 0:
|
||||
msg = msg + """
|
||||
The following packages have been checked successfully for upstream versions,
|
||||
but their recipes claim otherwise by setting UPSTREAM_VERSION_UNKNOWN. Please remove that line from the recipes.
|
||||
""" + "\n".join(regressed_successes)
|
||||
self.assertTrue(len(regressed_failures) == 0 and len(regressed_successes) == 0, msg)
|
||||
|
||||
def test_missing_homepg(self):
|
||||
"""
|
||||
Summary: Test for oe-core recipes that don't have a HOMEPAGE or DESCRIPTION
|
||||
Expected: All oe-core recipes should have a DESCRIPTION entry
|
||||
Expected: All oe-core recipes should have a HOMEPAGE entry except for recipes that are not fetched from external sources.
|
||||
Product: oe-core
|
||||
"""
|
||||
with bb.tinfoil.Tinfoil() as tinfoil:
|
||||
tinfoil.prepare(config_only=False)
|
||||
no_description = []
|
||||
no_homepage = []
|
||||
for fn in tinfoil.all_recipe_files(variants=False):
|
||||
if not '/meta/recipes-' in fn:
|
||||
# We are only interested in OE-Core
|
||||
continue
|
||||
rd = tinfoil.parse_recipe_file(fn, appends=False)
|
||||
pn = rd.getVar('BPN')
|
||||
srcfile = rd.getVar('SRC_URI').split()
|
||||
#Since DESCRIPTION defaults to SUMMARY if not set, we are only interested in recipes without DESCRIPTION or SUMMARY
|
||||
if not (rd.getVar('SUMMARY') or rd.getVar('DESCRIPTION')):
|
||||
no_description.append((pn, fn))
|
||||
if not rd.getVar('HOMEPAGE'):
|
||||
if srcfile and srcfile[0].startswith('file') or not rd.getVar('SRC_URI'):
|
||||
# We are only interested in recipes SRC_URI fetched from external sources
|
||||
continue
|
||||
no_homepage.append((pn, fn))
|
||||
if no_homepage:
|
||||
self.fail("""
|
||||
The following recipes do not have a HOMEPAGE. Please add an entry for HOMEPAGE in the recipe.
|
||||
""" + "\n".join(['%s (%s)' % i for i in no_homepage]))
|
||||
|
||||
if no_description:
|
||||
self.fail("""
|
||||
The following recipes do not have a DESCRIPTION. Please add an entry for DESCRIPTION in the recipe.
|
||||
""" + "\n".join(['%s (%s)' % i for i in no_description]))
|
||||
|
||||
def test_maintainers(self):
|
||||
"""
|
||||
Summary: Test that oe-core recipes have a maintainer and entries in maintainers list have a recipe
|
||||
Expected: All oe-core recipes (except a few special static/testing ones) should have a maintainer listed in maintainers.inc file.
|
||||
Expected: All entries in maintainers list should have a recipe file that matches them
|
||||
Product: oe-core
|
||||
Author: Alexander Kanavin <alex.kanavin@gmail.com>
|
||||
"""
|
||||
def is_exception(pkg):
|
||||
exceptions = ["packagegroup-",]
|
||||
for i in exceptions:
|
||||
if i in pkg:
|
||||
return True
|
||||
return False
|
||||
|
||||
def is_maintainer_exception(entry):
|
||||
exceptions = ["musl", "newlib", "linux-yocto", "linux-dummy", "mesa-gl", "libgfortran", "libx11-compose-data",
|
||||
"cve-update-nvd2-native",]
|
||||
for i in exceptions:
|
||||
if i in entry:
|
||||
return True
|
||||
return False
|
||||
|
||||
feature = 'require conf/distro/include/maintainers.inc\nLICENSE_FLAGS_ACCEPTED += " commercial"\nPARSE_ALL_RECIPES = "1"\nPACKAGE_CLASSES = "package_ipk package_deb package_rpm"\n'
|
||||
self.write_config(feature)
|
||||
|
||||
with bb.tinfoil.Tinfoil() as tinfoil:
|
||||
tinfoil.prepare(config_only=False)
|
||||
|
||||
with_maintainer_list = []
|
||||
no_maintainer_list = []
|
||||
|
||||
missing_recipes = []
|
||||
recipes = []
|
||||
prefix = "RECIPE_MAINTAINER:pn-"
|
||||
|
||||
# We could have used all_recipes() here, but this method will find
|
||||
# every recipe if we ever move to setting RECIPE_MAINTAINER in recipe files
|
||||
# instead of maintainers.inc
|
||||
for fn in tinfoil.all_recipe_files(variants=False):
|
||||
if not '/meta/recipes-' in fn:
|
||||
# We are only interested in OE-Core
|
||||
continue
|
||||
rd = tinfoil.parse_recipe_file(fn, appends=False)
|
||||
pn = rd.getVar('PN')
|
||||
recipes.append(pn)
|
||||
if is_exception(pn):
|
||||
continue
|
||||
if rd.getVar('RECIPE_MAINTAINER'):
|
||||
with_maintainer_list.append((pn, fn))
|
||||
else:
|
||||
no_maintainer_list.append((pn, fn))
|
||||
|
||||
maintainers = tinfoil.config_data.keys()
|
||||
for key in maintainers:
|
||||
if key.startswith(prefix):
|
||||
recipe = tinfoil.config_data.expand(key[len(prefix):])
|
||||
if is_maintainer_exception(recipe):
|
||||
continue
|
||||
if recipe not in recipes:
|
||||
missing_recipes.append(recipe)
|
||||
|
||||
if no_maintainer_list:
|
||||
self.fail("""
|
||||
The following recipes do not have a maintainer assigned to them. Please add an entry to meta/conf/distro/include/maintainers.inc file.
|
||||
""" + "\n".join(['%s (%s)' % i for i in no_maintainer_list]))
|
||||
|
||||
if not with_maintainer_list:
|
||||
self.fail("""
|
||||
The list of oe-core recipes with maintainers is empty. This may indicate that the test has regressed and needs fixing.
|
||||
""")
|
||||
|
||||
if missing_recipes:
|
||||
self.fail("""
|
||||
Unable to find recipes for the following entries in maintainers.inc:
|
||||
""" + "\n".join(['%s' % i for i in missing_recipes]))
|
||||
Reference in New Issue
Block a user